New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DRY `tags_max` calculation in _layouts/tags.html #1696

Merged
merged 1 commit into from Jun 4, 2018

Conversation

Projects
None yet
2 participants
@e28eta
Contributor

e28eta commented Jun 3, 2018

It was being done twice, and it doesn't seem to need to be.

DRY `tags_max` calculation in _layouts/tags.html
It was being done twice, and it doesn't seem to need to be.
@e28eta

This comment has been minimized.

Contributor

e28eta commented Jun 3, 2018

Again, thanks for all the hard work you do on this theme! As I was working on #1697, I saw this potential opportunity to clean it up.

I wasn't sure if you'd want both of these changes, so for simplicity I split it up.

@mmistakes

This comment has been minimized.

Owner

mmistakes commented Jun 4, 2018

Thanks for this. Looks good!

@mmistakes mmistakes merged commit e366a9a into mmistakes:master Jun 4, 2018

luispuerto referenced this pull request in luispuerto/luispuerto.net Jun 27, 2018

DRY `tags_max` calculation in _layouts/tags.html (#1696)
It was being done twice, and it doesn't seem to need to be.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment