Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix "analytics.provider" config comment to list all analytics providers. #2607

Merged
merged 1 commit into from
Jul 22, 2020
Merged

Fix "analytics.provider" config comment to list all analytics providers. #2607

merged 1 commit into from
Jul 22, 2020

Conversation

smanjo
Copy link
Contributor

@smanjo smanjo commented Jul 17, 2020

This is a documentation change.

Summary

The comment provided in _config.yml for analytics.provider is not complete (missing google-gtag).

The main config's analytics.provider comment was properly amended by the google-gtag feature commit (79d0b75), but the comment was reverted, possibly by bad merge, with an unrelated commit (bac26e9) two days later.

The docs and test configs appear to have never received the initial google-gtag update.

This change fixes all three configs' analytics.provider comments.

Context

Comments are good.

@smanjo
Fix config comment to list all analytics providers.
0a51d29 
The main config was properly updated with the google-gtag
feature commit (79d0b75), but was
removed, possibly by bad merge, with an unrelated commit
(bac26e9) two days later.

The docs and test configs appear to have never received the initial
google-gtag update.
@mmistakes
Copy link
Owner

Thanks @smanjo

@mmistakes mmistakes merged commit a0309bb into mmistakes:master Jul 22, 2020
mzaffran pushed a commit to mzaffran/mzaffran.github.io that referenced this pull request Jan 4, 2021
@smanjo
Fix config comment to list all analytics providers. (mmistakes#2607)
29cc124 
The main config was properly updated with the google-gtag
feature commit (79d0b75), but was
removed, possibly by bad merge, with an unrelated commit
(bac26e9) two days later.

The docs and test configs appear to have never received the initial
google-gtag update.
kaitokikuchi pushed a commit to kaitokikuchi/kaitokikuchi.github.io that referenced this pull request Sep 4, 2023
@smanjo
Fix config comment to list all analytics providers. (mmistakes#2607)
527835c 
The main config was properly updated with the google-gtag
feature commit (c528654), but was
removed, possibly by bad merge, with an unrelated commit
(662fbd0) two days later.

The docs and test configs appear to have never received the initial
google-gtag update.
chukycheese pushed a commit to chukycheese/chukycheese.github.io that referenced this pull request Sep 18, 2023
@smanjo @chukycheese
Fix config comment to list all analytics providers. (mmistakes#2607)
a10b016 
The main config was properly updated with the google-gtag
feature commit (79d0b75), but was
removed, possibly by bad merge, with an unrelated commit
(bac26e9) two days later.

The docs and test configs appear to have never received the initial
google-gtag update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Bug Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@smanjo @mmistakes