Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Discourse noscript link #699

Merged
merged 1 commit into from Dec 5, 2016
Merged

Fix Discourse noscript link #699

merged 1 commit into from Dec 5, 2016

Conversation

t-richards
Copy link
Contributor

@t-richards t-richards commented Dec 5, 2016

What does this PR do?

  • Changes the link in the Discourse comments template, <noscript> section, to point to the Discourse.org homepage instead of a specific instance of Discourse (beta-europe.org).

Why?

This has been changed because the original "link" looks like a mistake:

  • It does not appear to be related to this project,
  • It is in Markdown format - Markdown is not parsed in this .html partial, and,
  • There is a stray </a> tag after it.

@mmistakes mmistakes merged commit 86c2fb4 into mmistakes:develop Dec 5, 2016
@t-richards t-richards deleted the discourse-noscript branch December 5, 2016 04:50
RobinYu added a commit to RobinYu/robinyuuu.github.io that referenced this pull request Jan 3, 2017
jluccisano added a commit to jluccisano/jluccisano.github.io that referenced this pull request May 6, 2017
martinbjeldbak added a commit to martinbjeldbak/martinbjeldbak.github.io that referenced this pull request Feb 1, 2018
* upstream/master:
  New comment. (mmistakes#751)
  New comment. (mmistakes#750)
  Fix typo
  New comment. (mmistakes#745)
  New comment. (mmistakes#743)
  New comment. (mmistakes#729)
  Bump version to 4.1.1
  Update CHANGELOG.md and history
  Remove hardcoded read time values and make “minute read” values dynamic based off of `site.words_per_minute` - Close mmistakes#703
  Fix `author.youtube` conditional in author sidebar
  Change Jekyll to a runtime dependency
  Add support for YouTube channel URLs in `/docs` author sidebar
  Add support for YouTube channel URLs in author sidebar - Close mmistakes#716
  Update Font Awesome to v4.7.0 in `/docs`
  Update Font Awesome to v4.7.0 - Close mmistakes#723
  Bump version to 4.1.0
  Update CHANGELOG and history
  Add include for adding custom author profile links to sidebar
  Fix padding issue with pagination buttons - Close mmistakes#694
  Fix link to Discourse.org homepage in noscript section (mmistakes#699)
kkunapuli pushed a commit to kkunapuli/kkunapuli.github.io that referenced this pull request May 30, 2019
makaroniame added a commit to makaroniame/makaroniame-old.github.io that referenced this pull request May 18, 2022
jchwenger pushed a commit to jchwenger/jchwenger.github.io that referenced this pull request May 5, 2023
koyumi0601 pushed a commit to koyumi0601/koyumi0601.github.io that referenced this pull request Jul 31, 2023
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants