Do not show footer in entry.html if not needed. #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If there is no site.read_time or entry.date set, do not show an empty footer as this only adds some whitespace. In a collection without excerpts the whitespace between headers is already quite a lot due to the article tag, so at least, do not add additional unnecessary whitespace. Signed-off-by: Vangelis Tasoulas <vangelis@tasoulas.net>
|
Thanks for PR, looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is no
site.read_timeorentry.dateset, do not show an emptyfooter as this only adds some whitespace. In a collection without
excerpts the whitespace between headers is already quite a lot due to
the article tag, so at least, do not add additional unnecessary
whitespace.
Note that the
entry.dateis not printed in a collection anyways (look at theentry-date.html), that why theentry.date and page.layout != 'collection'part of the code in the if statement.