-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement single-song repeat mode #72
Conversation
Using the command line flag `-L` will now loop a single song repeatedly.
Instead of adding a new flag, I think it would be reasonable that if you set |
Actually, you can already loop a single song, e.g.: |
Oh wow I totally missed that. Thanks for the tip! |
Actually there is a subtle difference between
Is this a use-case that would warrant the |
I'll re-open and let you make the call as the project lead. As long as there's some way to loop songs I'll be happy. For some reason this is the only gbs player that properly emulates everything thrown at it. Music players that integrate Game Music Emu fail to play songs correctly and even in some cases crash the music application. So thanks for creating and maintaining a great program! |
Sorry I wasn't clear before. Yes your assumption is correct that this is the intended behavior. You can keep single-song-repeat mode on and change the subsong without restarting the application. |
I think it's a useful feature and it also seems legit to use both
My intention with |
Are you suggesting a sub-range of subsongs played as a playlist? For example, suppose a gbs pack had 10 subsongs. Then the user runs the following command. $ gbsplay -L -l songs.gbs 2 4 subsong 2 begins playing and doesn't change until the user presses If that's the case I don't think this is how the Running the command then pressing $ gbsplay -l songs.gbs 2 4 Only once the current subsong reaches 2 through 4, it will loop through subsongs (2-4] again. |
You're right:
I think the easiest course of action would be to just add something like -l and -L are mutually exclusive to the manpage. But I don't know about the short help text. Should that be mentioned there? Or would it be clear that both options don't work together? (cough cough in my last post I wrote the opposite ;-) I still like I'll merge the change, but we could still tweak the wording. |
BTW I think a fair number of GBS have the subsong run forever, so if you disable the gbsplay subsong timeout using
That's fairly broken behavior, it should just behave like the |
Should the "loop single subsong" mode ( |
This way we can modify the timeout behavior based on loop mode. For LOOP_SINGLE the subsong timeout is ignored since many GBS subsongs just play forever anyway. By letting them continue indefinitely there is no fadeout break in the song in single song loop mode. See #72 (comment)
I've added a description of the loop modes to the man page with 04d709f. I think we're ready to close this issue or am I missing anything? |
d'oh: "merged" already means closed, I just have to set the thread to done in my notifications ;-) |
Hey all, not sure how important this is to anyone else but I sometimes like to loop a song.
Using the command line flag
-L
will now loop a single song repeatedly.