Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overloaded multi commands have incorrect type #270

Closed
scola84 opened this issue Dec 30, 2020 · 3 comments · Fixed by #271
Closed

Overloaded multi commands have incorrect type #270

scola84 opened this issue Dec 30, 2020 · 3 comments · Fixed by #271

Comments

@scola84
Copy link

scola84 commented Dec 30, 2020

When I try to use xadd on a batch I am forced to provide the NOMKSTREAM option, while there are four xadd definitions available. It seems as if in multi.ts#L52 only the last one is added to the batch/multi interface.
@mmkal
Copy link
Owner

mmkal commented Dec 31, 2020

Ah, I think this is a limitation of the Parameters<...> built-in type (see microsoft/TypeScript#32164). I'll look into whether the whole multi/batch interface can be generated like the regular commands.

@mmkal mmkal mentioned this issue Dec 31, 2020
Merged
@mmkal mmkal closed this as completed in #271 Jan 3, 2021
@mmkal
Copy link
Owner

mmkal commented Jan 3, 2021

@scola84 fix released in v2.2.0

@scola84
Copy link
Author

scola84 commented Jan 4, 2021

Successfully integrated, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multi overloads mmkal/handy-redis
2 participants
@scola84 @mmkal