Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi overloads #271

Merged
merged 1 commit into from
Jan 3, 2021
Merged

Multi overloads #271

merged 1 commit into from
Jan 3, 2021

Conversation

mmkal
Copy link
Owner

@mmkal mmkal commented Dec 31, 2020

Fixes #270

@codecov-io
Copy link

codecov-io commented Dec 31, 2020

Codecov Report

Merging #271 (dfaf1a2) into master (864eae9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #271   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           12        12           
  Lines          479       479           
  Branches       105       105           
=========================================
  Hits           479       479           
Impacted Files Coverage Δ
src/node_redis/multi.ts 100.00% <ø> (ø)
codegen/generate-client.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 864eae9...dfaf1a2. Read the comment docs.

This allows returning a chainable multi interface which works with all overloads.
@mmkal mmkal merged commit 677af10 into master Jan 3, 2021
@mmkal mmkal deleted the multi-overloads branch January 3, 2021 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overloaded multi commands have incorrect type
2 participants