Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

m-image emissive attribute #187

Merged
merged 1 commit into from
Jul 11, 2024
Merged

Conversation

TheCodeTherapy
Copy link
Contributor

This PR adds the emissive attribute to the <m-image> tag on mml-web. This allows the user to specify the emissive strength of the image's generated texture (how much perceived light it will emit).


What kind of changes does your PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Refactor
  • Tests
  • Other, please describe:

Does your PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe its impact and migration path for existing applications:

Does your PR fulfill the following requirements?

  • All tests are passing
  • The title references the corresponding issue # (if relevant)

Screenshot 2024-07-10 at 16 51 06

@TheCodeTherapy TheCodeTherapy merged commit c633dc6 into main Jul 11, 2024
8 checks passed
@TheCodeTherapy TheCodeTherapy deleted the feature/image-emissiveness branch July 11, 2024 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants