Fix JSDOMRunner Typescript errors #33
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcusLongmuir
approved these changes
Jun 25, 2023
|
Thanks for this! Ideally the types would be emit without depending on the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some errors appear when pulling the
@mml-io/observable-dominto a project with default tsconfig.json options (tsc --init) and trying to compile (see attached screenshot). The proposed diff fixes them. The nullable types could certainly be handled differently; feel free to attach further changes to this PR – maintainer edits are allowed.npm run lint-allruns successfully with these changes. Tests I did not verify locally because of (likely unrelated) errors.What kind of changes does your PR introduce? (check at least one)
Does your PR introduce a breaking change? (check one)
Does your PR fulfill the following requirements?