Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: TypeScript types depend on src #36

Closed
MarcusLongmuir opened this issue Jun 26, 2023 · 0 comments · Fixed by #75
Closed

[Bug]: TypeScript types depend on src #36

MarcusLongmuir opened this issue Jun 26, 2023 · 0 comments · Fixed by #75
Labels
bug Something isn't working

Comments

@MarcusLongmuir
Copy link
Collaborator

Describe the bug

The TypeScript types specified by the libraries defined in this repository are an immediate indirection to the src directories which means that all dependent projects must parse the src with their own version of TypeScript and tsconfig rules.

This is problematic as version mismatches or increased strictness prevents the types being valid. See #33

Expected behavior

There are .d.ts files output for each library that are generated from the src without depending on the src directly.

How to reproduce the bug

Depend on a library such as mml-web and then increase the strictness / change the tsconfig.json for the dependent project. You are likely to get type errors.

Link to the code that reproduces this bug

No response

Packages

mml-web etc.

Package versions

0.1.1

Extra details

No response

@MarcusLongmuir MarcusLongmuir added the bug Something isn't working label Jun 26, 2023
@MarcusLongmuir MarcusLongmuir changed the title [Bug]: [Bug]: TypeScript types depend on src Jun 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: 🚢 Released
Development

Successfully merging a pull request may close this issue.

1 participant