Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add repeat function #51

Closed
paperluigis opened this issue Oct 24, 2020 · 7 comments
Closed

add repeat function #51

paperluigis opened this issue Oct 24, 2020 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@paperluigis
Copy link

paperluigis commented Oct 24, 2020

Please, add repeat function! [ask for a function]

Sometimes, I want to listen to music more than it's length.

@mmontag mmontag added the enhancement New feature or request label Nov 19, 2020
@mmontag mmontag self-assigned this Nov 19, 2020
@mmontag
Copy link
Owner

mmontag commented Nov 19, 2020

Many game songs were meant to repeat so I think this is even more important for a retro music player.
It's on my list of things to do!

@paperluigis
Copy link
Author

Many game songs were meant to repeat so I think this is even more important for a retro music player.
It's on my list of things to do!

Thanks! =)

@mankeli
Copy link

mankeli commented Dec 12, 2020

I definitely vote for this! What a great player and UI otherwise!

mmontag added a commit that referenced this issue Dec 14, 2020
@mmontag
Copy link
Owner

mmontag commented Dec 14, 2020

Added a repeat button. It cycles through 3 modes (Repeat-All, Repeat-One, Off).

@mmontag mmontag closed this as completed Dec 14, 2020
@mmontag
Copy link
Owner

mmontag commented Dec 14, 2020

Note that repeat-one mode won't repeat subtracks within NSF files.
It's a Sequencer-level repeat, so it also doesn't utilize loop points defined in song metadata.
Feel free to open another issue if that really bothers you :)

mmontag added a commit that referenced this issue Dec 14, 2020
@mankeli
Copy link

mankeli commented Dec 14, 2020

NSF files are program code, any song length is defined afterwards. Game rips often play forever and so does most of the "scene" songs. This is also true for several other song formats. (SPC, SID, etc) Mod files also often rely on the "implicit" looping that the player just wraps to pattern 0 seamlessly, and there are also "jump to order" repeat commands in mod files.

I guess the repeat feature should use this if it's available?

@paperluigis
Copy link
Author

Oh thank you!
I already knew songs could repeat, slowly watching how pattern 39 (for example) jumps back to pattern 5, excluding the start, making the length of song infinite.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants