Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBRT api header file ? #203

Closed
nyue opened this issue Oct 17, 2018 · 1 comment
Closed

PBRT api header file ? #203

nyue opened this issue Oct 17, 2018 · 1 comment

Comments

@nyue
Copy link
Contributor

nyue commented Oct 17, 2018

Hi,

In the book, there is a mentioned of core/api.h

I build and install the current master but there was no api.h in the destination include directory.

Is the api.h meant to be install via the standard build+install approach ? Are there other PBRT header file that should be installed for client code to build ?

Cheers

@mmp
Copy link
Owner

mmp commented Oct 20, 2018

That stuff isn't super well specified unfortunately (and nothing is installed currently; see also #2 ).

e.g. api.h includes pbrt.h, which, in addition to regular system headers, includes core/error.h and glog/logging.h (even though neither is needed in this particular case.) However, to use api.h one almost certainly needs core/paramset.h, and that in turn includes a bunch of stuff, etc.

The most expedient thing is to probably install just about all the headers in core/ , or to just point at them directly. :-p

@mmp mmp closed this as completed Oct 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants