[Tabs] Fix ref type (mui#38717)

mnajdova · Sep 8, 2023 · 8750cfb · 8750cfb
1 parent 23348ba
commit 8750cfb
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/mui-material/src/Tabs/Tabs.d.ts b/packages/mui-material/src/Tabs/Tabs.d.ts
@@ -3,7 +3,6 @@ import { SxProps } from '@mui/system';
 import { SlotComponentProps } from '@mui/base';
 import { OverridableStringUnion } from '@mui/types';
 import { Theme } from '../styles';
-import ButtonBase from '../ButtonBase';
 import { TabScrollButtonProps } from '../TabScrollButton';
 import { OverridableComponent, OverrideProps } from '../OverridableComponent';
 import { TabsClasses } from './tabsClasses';
@@ -176,7 +175,7 @@ export interface TabsOwnProps {
 
 export interface TabsTypeMap<
   AdditionalProps = {},
-  RootComponent extends React.ElementType = typeof ButtonBase,
+  RootComponent extends React.ElementType = 'div',
 > {
   props: AdditionalProps & TabsOwnProps;
   defaultComponent: RootComponent;

diff --git a/packages/mui-material/src/Tabs/Tabs.spec.tsx b/packages/mui-material/src/Tabs/Tabs.spec.tsx
@@ -1,4 +1,5 @@
 import * as React from 'react';
+import { expectType } from '@mui/types';
 import Tabs from '@mui/material/Tabs';
 import SvgIcon from '@mui/material/SvgIcon';
 
@@ -50,3 +51,10 @@ function SampleIcon() {
     }),
   }}
 />;
+
+// Test for ref type
+<Tabs
+  ref={(elem) => {
+    expectType<HTMLDivElement | null, typeof elem>(elem);
+  }}
+/>;