Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Fix ref type #38717

Merged
merged 4 commits into from
Aug 30, 2023
Merged

Conversation

ZeeshanTamboli
Copy link
Member

@ZeeshanTamboli ZeeshanTamboli commented Aug 30, 2023

Fixes #38391

Correct the default component type, which will also resolve the issue with the ref type.

Before: https://codesandbox.io/s/crazy-euler-2c5s48?file=/Demo.tsx
After: https://codesandbox.io/s/jovial-panini-yvmwx9?file=/Demo.tsx

@ZeeshanTamboli ZeeshanTamboli added bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! typescript package: material-ui Specific to @mui/material labels Aug 30, 2023
@mui-bot
Copy link

mui-bot commented Aug 30, 2023

Netlify deploy preview

https://deploy-preview-38717--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against edaff5c

@ZeeshanTamboli ZeeshanTamboli marked this pull request as ready for review August 30, 2023 06:15
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 30, 2023
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Aug 30, 2023
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@ZeeshanTamboli ZeeshanTamboli merged commit e835110 into mui:master Aug 30, 2023
18 checks passed
@ZeeshanTamboli ZeeshanTamboli deleted the issue-38391-tabs-ref-type branch August 30, 2023 12:53
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
mnajdova pushed a commit to mnajdova/material-ui that referenced this pull request Sep 8, 2023
@IlyaShorin
Copy link

still see incorrect type as HTMLButtonElement

@ZeeshanTamboli
Copy link
Member Author

@IlyaShorin Which version of @mui/material are you using? This was fixed in @mui/material v5.14.8. If the issue persists, please create a new issue with a reproduction.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: tabs This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tabs] ref is incorrectly typed as HTMLButtonElement whereas it's in fact HTMLDivElement
4 participants