private -> protected accessibility for overloading #31
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to develop Single command applications it is required to use the defaultCommand. To do we need to overload the
ExpressionParser
. In the method parse we need to disable the line:and later passing of the name:
There would be no problem in that, but since methods like
parseOption
,startsWith
(etc.) are private it is required to repeat them in the child class. Having them protected would allow use of inheritance:Going further, we need to update the method
createCommand
, but we also need to overloadcommand
as it callscreateCommand
of the parent scope if not overloaded. If overloaded then we need to repeatassertCallableIsValid
(etc.) again to be accessible.