Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
  • Loading branch information
hoechenberger committed Mar 4, 2022
1 parent 2bda182 commit 6d42709
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ Enhancements

- Similarly, :func:`mne_bids.get_head_mri_trans` and :func:`mne_bids.update_anat_landmarks` gained a new ``kind`` parameter to specify which of multiple landmark sets to operate on, by `Alexandre Gramfort`_ and `Richard Höchenberger`_ (:gh:`955`, :gh:`957`)

- Add support for ieeg data in the coordinate frame 'Pixels'; although MNE does not recognize this coordinate frame and so it will be set to "unknown" in the montage, MNE can still be used to analyze this kind of data, by `Alex Rockhill`_ (:gh:`976`)
- Add support for iEEG data in the coordinate frame ``Pixels``; although MNE-Python does not recognize this coordinate frame and so it will be set to ``unknown`` in the montage, MNE-Python can still be used to analyze this kind of data, by `Alex Rockhill`_ (:gh:`976`)

API and behavior changes
^^^^^^^^^^^^^^^^^^^^^^^^
Expand Down Expand Up @@ -76,7 +76,7 @@ Bug fixes

- :func:`mne_bids.get_head_mri_trans` now respects ``datatype`` and ``suffix`` of the provided electrophysiological :class:`mne_bids.BIDSPath`, simplifying e.g. reading of derivaties, by `Richard Höchenberger`_ (:gh:`969`)

- Fix datasets with unknown coordinate frames being transformed to "head" by assuming an identity transform, by `Alex Rockhill`_ (:gh:`976`)
- Do not convert unknown coordinate frames to ``head``, by `Alex Rockhill`_ (:gh:`976`)

:doc:`Find out what was new in previous releases <whats_new_previous_releases>`

Expand Down
3 changes: 2 additions & 1 deletion mne_bids/tests/test_write.py
Original file line number Diff line number Diff line change
Expand Up @@ -3594,4 +3594,5 @@ def test_write_dig(tmpdir):
assert montage2.get_positions()['coord_frame'] == 'unknown'
assert_array_almost_equal(
np.array(list(montage.get_positions()['ch_pos'].values())),
np.array(list(montage2.get_positions()['ch_pos'].values())))
np.array(list(montage2.get_positions()['ch_pos'].values()))
)

0 comments on commit 6d42709

Please sign in to comment.