[MRG] update function to raw_to_bids #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teonbrooks
force-pushed
the
raw_to_bids
branch
from
ea91961
to
ce7f8cb
Compare
|
@teonbrooks can you update one example so I can try it? |
thanks @MartinPerez and @jasmaniak for the .tolist() suggestion
there’s no plotting. making the name reflect what the example is doing
teonbrooks
changed the title
|
ready for review |
|
@teonbrooks have you given up on pep8? ;P never mind, I'll make a cleanup commit and merge :) |
|
Merged. Thanks @teonbrooks |
|
lol this was a hilarious final few moments of this pr |
wait? what pep8 errors?! I only write beautiful code! |
|
upon further review, maybe I need to properly configure my linter ;) also, we should have ci for it! |
or maybe start using Sublime text instead of fancy-pants Atom :P |
|
or maybe start using Sublime text instead of fancy-pants Atom :P
+1
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.