MRG: Don't store invalid weight and height in info['subject_info']; write weight and height to participants.tsv #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoechenberger
force-pushed
the
hoechenberger/issue1027
branch
from
2374468
to
2cfd24a
Compare
hoechenberger
force-pushed
the
hoechenberger/issue1027
branch
from
2cfd24a
to
e679aa0
Compare
hoechenberger
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1031 +/- ##
==========================================
+ Coverage 95.18% 95.19% +0.01%
==========================================
Files 25 25
Lines 3778 3787 +9
==========================================
+ Hits 3596 3605 +9
Misses 182 182
Help us with your feedback. Take ten seconds to tell us how you rate us. |
hoechenberger
force-pushed
the
hoechenberger/issue1027
branch
from
b89e8a4
to
018b081
Compare
hoechenberger
changed the title
agramfort
reviewed
Jul 30, 2022
hoechenberger
commented
Jul 30, 2022
…e-bids into hoechenberger/issue1027
hoechenberger
changed the title
adam2392
approved these changes
Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1027
@eort this should fix your problem.
info['subject_info']always exists after reading, and that it's always a dictinfo['subject_info']before injecting the info fromparticipants.tsv. Previously, we simply altered / amended the existing data structure, which could've led to a melange of BIDS and non-BIDS data.PR Description
Describe your PR here
Merge checklist
Maintainer, please confirm the following before merging: