Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] handle empty TSVs robustly and warn #1038

Merged
merged 5 commits into from
Aug 4, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Aug 4, 2022

PR Description

closes #925

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@sappelhoff sappelhoff changed the title handle empty TSVs robustly and warn [MRG] handle empty TSVs robustly and warn Aug 4, 2022
@codecov
Copy link

codecov bot commented Aug 4, 2022

Codecov Report

Merging #1038 (fd853ef) into main (be6bd62) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1038      +/-   ##
==========================================
- Coverage   95.16%   95.15%   -0.02%     
==========================================
  Files          25       25              
  Lines        3786     3796      +10     
==========================================
+ Hits         3603     3612       +9     
- Misses        183      184       +1     
Impacted Files Coverage Δ
mne_bids/tsv_handler.py 100.00% <100.00%> (ø)
mne_bids/write.py 97.04% <0.00%> (-0.11%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, just one small request

mne_bids/tsv_handler.py Outdated Show resolved Hide resolved
Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hoechenberger hoechenberger enabled auto-merge (squash) August 4, 2022 14:27
@hoechenberger

This comment was marked as resolved.

@hoechenberger hoechenberger merged commit 122f268 into mne-tools:main Aug 4, 2022
@sappelhoff sappelhoff deleted the empty/tsv branch August 4, 2022 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gracefully handle situations where TSV files only contain the column headers
2 participants