Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MRG: Remove special-casing for NIRS bids-validator #1063

Merged
merged 1 commit into from
Sep 1, 2022
Merged

MRG: Remove special-casing for NIRS bids-validator #1063

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
28 changes: 2 additions & 26 deletions .github/workflows/unit_tests.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,22 +124,6 @@ jobs:
mne-version: mne-main
bids-validator-version: validator-main

# Tests with the NIRS branch of bids-validator
- os: ubuntu-latest
python-version: "3.10"
mne-version: mne-main
bids-validator-version: validator-NIRS

- os: macos-latest
python-version: "3.10"
mne-version: mne-main
bids-validator-version: validator-NIRS

- os: windows-latest
python-version: "3.10"
mne-version: mne-main
bids-validator-version: validator-NIRS

env:
TZ: Europe/Berlin
FORCE_COLOR: true
Expand Down Expand Up @@ -197,16 +181,8 @@ jobs:
popd
echo "BIDS_VALIDATOR_BRANCH=main" >> $GITHUB_ENV

- name: Download BIDS validator (NIRS)
if: "matrix.bids-validator-version == 'validator-NIRS'"
run: |
pushd ..
git clone --depth 1 --branch nirs https://github.com/rob-luke/bids-validator.git
popd
echo "BIDS_VALIDATOR_BRANCH=NIRS" >> $GITHUB_ENV

- name: Install BIDS validator (main or NIRS)
if: ${{ (matrix.bids-validator-version == 'validator-main') || (matrix.bids-validator-version == 'validator-NIRS') }}
- name: Install BIDS validator (main)
if: "matrix.bids-validator-version == 'validator-main'"
run: |
pushd ..
cd bids-validator
Expand Down
4 changes: 0 additions & 4 deletions mne_bids/tests/test_write.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1719,10 +1719,6 @@ def test_eegieeg(dir_name, fname, reader, _bids_validate, tmp_path):
_bids_validate(output_path)


@pytest.mark.skipif(
os.environ.get('BIDS_VALIDATOR_BRANCH') != 'NIRS',
reason="requires Rob's NIRS branch of bids-validator"
)
def test_snirf(_bids_validate, tmp_path):
"""Test write_raw_bids conversion for SNIRF data."""
raw_fname = op.join(testing.data_path(), 'SNIRF', 'MNE-NIRS', '20220217',
Expand Down