[MRG]: Add support for reading curry EEG files #1072
Conversation
|
Hello! 👋 Thanks for opening your first pull request here! ❤️ We will try to get back to you soon. 🚴🏽♂️ |
|
Merging main just to be safe 😇 |
|
@dengemann it appears the .dat extension is already in use for another reader.. maybe let's restrict ourselves to .cdt here? |
OK, that would move curry support to version > 7 Or does it mean that more sophisticated checks are needed? |
|
also we did not updated whats new etc. |
|
@sappelhoff We have a one-to-many mapping here, |
|
... perhaps we don't support it for now and wait till someone asks for it. I am personally OK with .cdt support as it solves my problem. |
|
+1 for .cdt
… Message ID: ***@***.***>
|
|
+1, let's only do |
|
shall I open the PR again / continue or will you take over @hoechenberger ? |
|
Please do work on this one as far / long as you can, @dengemann :) I don't have much time currently |
|
#1073 pushes commits that |
|
Pulled in |
Codecov Report
@@ Coverage Diff @@
## main #1072 +/- ##
=======================================
Coverage 95.21% 95.21%
=======================================
Files 24 24
Lines 3845 3845
=======================================
Hits 3661 3661
Misses 184 184
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
@dengemann can you look into CI failures? |
|
Alright, made some progress here. CIs happy except for coverage. |
|
Ok it semes all is fine now. |
mne_bids/config.py
Outdated
| @@ -59,7 +59,8 @@ | |||
| '.lay': 'Persyst', '.dat': 'Persyst', | |||
| '.EEG': 'Nihon Kohden', | |||
| '.cnt': 'Neuroscan', '.CNT': 'Neuroscan', | |||
| '.bin': 'EGI'} | |||
| '.bin': 'EGI', | |||
| '.cdt': 'n/a'} | |||
There was a problem hiding this comment.
in my understanding Curry is used by different amps / manufacturers
There was a problem hiding this comment.
ah sorry. got confused. yes we could do "curry" for the fileformat
| @@ -24,7 +24,7 @@ Version 0.11 (unreleased) | |||
|
|
|||
| The following authors contributed for the first time. Thank you so much! 🤩 | |||
|
|
|||
| * ... | |||
| * `Denis Engemann`_ | |||
There was a problem hiding this comment.
@dengemann you need to update authors.rst too
dengemann
changed the title
|
🎉 Congrats on merging your first pull request! 🥳 Looking forward to seeing more from you in the future! 💪 |
PR Description
This adds support for curry eeg files as input, closes #1070.
On local machine, not all tests pass on main branch, hence, I am not sure what certain test results mean for curry branch.
Let's see what CI's will say.
Merge checklist
Maintainer, please confirm the following before merging.
If applicable: