Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] FIX: Convert line_freq and overwrite to proper types in CLI #1125

Merged
merged 6 commits into from Mar 9, 2023

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Mar 8, 2023

PR Description

fixes #1124

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@sappelhoff
Copy link
Member Author

@achilleasNP could you please try whether the changes here fix your problem?

You can install this version using: pip install git+https://github.com/sappelhoff/mne-bids.git@clifix

And then uninstall (pip uninstall mne-bids) after your test and re-install your actual version as you did before.

@codecov
Copy link

codecov bot commented Mar 8, 2023

Codecov Report

Merging #1125 (a01a6f8) into main (0b1a61d) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1125   +/-   ##
=======================================
  Coverage   95.29%   95.29%           
=======================================
  Files          40       40           
  Lines        8670     8676    +6     
=======================================
+ Hits         8262     8268    +6     
  Misses        408      408           
Impacted Files Coverage Δ
mne_bids/commands/tests/test_cli.py 96.61% <ø> (ø)
mne_bids/commands/mne_bids_raw_to_bids.py 95.45% <100.00%> (+0.71%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but could you add a changelog entry?

@achilleasNP
Copy link

@sappelhoff I just tested it and the commit fixes my problem.

Thank you!

@sappelhoff sappelhoff changed the title FIX: Convert line_freq and overwrite to proper types in CLI [MRG] FIX: Convert line_freq and overwrite to proper types in CLI Mar 8, 2023
@sappelhoff sappelhoff merged commit f053191 into mne-tools:main Mar 9, 2023
@sappelhoff sappelhoff deleted the clifix branch March 9, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

command raw_to_bids takes overwrite and line_freq as text and fails for brainvision format
4 participants