Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Fix copyfile_eeglab type conflicts #1126

Merged
merged 3 commits into from
Mar 8, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/whats_new.rst
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,7 @@ Detailed list of changes
^^^^^^^^^^^^

- Amending a dataset now works in cases where the newly-written data contains additional participant properties (new columns in ``participants.tsv``) not found in the existing dataset, by `Richard Höchenberger`_ (:gh:`1113`)
- Fixes :func:`~mne_bids.copyfiles.copyfile_eeglab` to prevent data type conversion leading to an ``eeg_checkset`` failure when trying to load the file in EEGLAB, by `Laetitia Fesselier`_ (:gh:`1122`)

:doc:`Find out what was new in previous releases <whats_new_previous_releases>`

Expand Down
9 changes: 9 additions & 0 deletions mne_bids/copyfiles.py
Original file line number Diff line number Diff line change
Expand Up @@ -564,6 +564,15 @@ def copyfile_eeglab(src, dest):
new_value[0, 0] = np.atleast_1d(np.array(tail))
eeg['data'] = new_value

# Make sure all values are saved as float
# (see https://github.com/mne-tools/mne-bids/issues/1122)
eeg['nbchan'] = float(eeg['nbchan'])
eeg['pnts'] = float(eeg['pnts'])
eeg['trials'] = float(eeg['trials'])
eeg['srate'] = float(eeg['srate'])
eeg['xmin'] = float(eeg['xmin'])
eeg['xmax'] = float(eeg['xmax'])
sappelhoff marked this conversation as resolved.
Show resolved Hide resolved

# Save the EEG dictionary as a Matlab struct again
mdict = dict(EEG=eeg) if oldstyle else eeg
savemat(file_name=dest, mdict=mdict, appendmat=False)
Expand Down