Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run unit tests on Apple Silicon and bump Node version to LTS (currently 20) #1231

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Run unit tests on Apple Silicon and bump Node version to LTS (currently 20) #1231

merged 3 commits into from
Mar 7, 2024

Conversation

hoechenberger
Copy link
Member

Merge checklist

Maintainer, please confirm the following before merging.
If applicable:

  • All comments are resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • New contributors have been added to CITATION.cff
  • PR description includes phrase "closes <#issue-number>"

@hoechenberger
Copy link
Member Author

blocked by #1233

@codecov Codecov
Copy link

codecov bot commented Mar 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.59%. Comparing base (87eea28) to head (2b619a3).
Report is 10 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1231      +/-   ##
==========================================
- Coverage   97.61%   97.59%   -0.02%     
==========================================
  Files          40       40              
  Lines        8685     8663      -22     
==========================================
- Hits         8478     8455      -23     
- Misses        207      208       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sappelhoff
sappelhoff approved these changes Mar 7, 2024
View reviewed changes
Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks

@sappelhoff sappelhoff enabled auto-merge (squash) March 7, 2024 17:16
@hoechenberger
Copy link
Member Author

@sappelhoff I will take care of the failing CI job

@sappelhoff sappelhoff merged commit dbadf8a into mne-tools:main Mar 7, 2024
18 of 20 checks passed
@hoechenberger
Copy link
Member Author

@sappelhoff I think you merged a failing branch :) I'll open a follow-up PR to fix this

@hoechenberger hoechenberger mentioned this pull request Mar 7, 2024
Merged
7 tasks
@sappelhoff
Copy link
Member

urgs, sorry.

@hoechenberger
Copy link
Member Author

urgs, sorry.

No worries, happens … I think it got auto-merged because the new CI job had naturally not been added to the branch protection rules yet!

sappelhoff added a commit that referenced this pull request Mar 7, 2024
@hoechenberger @sappelhoff
Fixup for #1231 (#1234)
326ebe2 
* Run unit tests on Apple Silicon and bump Node version to LTS (currently 20)

* Update unit_tests.yml

* Only test Apple Silicon with Python 3.12

* Typo

---------

Co-authored-by: Stefan Appelhoff <stefan.appelhoff@mailbox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sappelhoff sappelhoff sappelhoff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hoechenberger @sappelhoff