Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] add required python version to setup.py #320

Merged
merged 1 commit into from
Dec 7, 2019

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Dec 7, 2019

closes #314

Describe your PR here

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"
  • Commit history does not contain any merge commits

@codecov-io
Copy link

codecov-io commented Dec 7, 2019

Codecov Report

Merging #320 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #320   +/-   ##
=======================================
  Coverage   94.79%   94.79%           
=======================================
  Files          11       11           
  Lines        1152     1152           
=======================================
  Hits         1092     1092           
  Misses         60       60

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 72e1bd3...31d625a. Read the comment docs.

@sappelhoff
Copy link
Member Author

same for this one @jasmainak please check and merge if all is well.

@jasmainak jasmainak changed the title add required python version to setup.py [MRG] add required python version to setup.py Dec 7, 2019
@jasmainak jasmainak merged commit 901c385 into mne-tools:master Dec 7, 2019
@jasmainak
Copy link
Member

Thanks @sappelhoff !

@sappelhoff sappelhoff deleted the setit branch December 7, 2019 22:48
dominikwelke pushed a commit to dominikwelke/mne-bids that referenced this pull request Feb 7, 2020
dominikwelke pushed a commit to dominikwelke/mne-bids that referenced this pull request Feb 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[joss] list supported python versions in pypi
4 participants