Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Include 'part' in the entity list #346

Merged
merged 4 commits into from Jan 23, 2020

Conversation

teonbrooks
Copy link
Member

@teonbrooks teonbrooks commented Jan 22, 2020

Update utils.py

Thanks for contributing. If this is your first time,
make sure to read contributing.md

PR Description

part is missing from the entity list. It is introduced for the fif files in the appendix but it isn't being captured in our parsing step

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"
  • Commit history does not contain any merge commits

@teonbrooks teonbrooks changed the title Include 'part' in the entity list [MRG] Include 'part' in the entity list Jan 22, 2020
@jasmainak
Copy link
Member

test please :-)

@codecov-io
Copy link

codecov-io commented Jan 22, 2020

Codecov Report

Merging #346 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #346   +/-   ##
=======================================
  Coverage   95.14%   95.14%           
=======================================
  Files          11       11           
  Lines        1277     1277           
=======================================
  Hits         1215     1215           
  Misses         62       62
Impacted Files Coverage Δ
mne_bids/utils.py 98.3% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d8c279...167a847. Read the comment docs.

@teonbrooks
Copy link
Member Author

@jasmainak it's all good to go

@jasmainak
Copy link
Member

do you want to update whats_new.rst? otherwise, it's good to go

@jasmainak jasmainak added this to In progress in 0.4 via automation Jan 22, 2020
@teonbrooks teonbrooks force-pushed the include_part branch 4 times, most recently from c6f2376 to 32220c4 Compare January 22, 2020 20:50
@jasmainak
Copy link
Member

sorry there are merge conflicts now ...

@jasmainak jasmainak merged commit d3d7ef2 into mne-tools:master Jan 23, 2020
0.4 automation moved this from In progress to Done Jan 23, 2020
@jasmainak
Copy link
Member

Thanks @teonbrooks !

@teonbrooks teonbrooks deleted the include_part branch January 23, 2020 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
0.4
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants