Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Adding status_description to channels.tsv files defaulting to n/a for now #489

Merged
merged 2 commits into from Aug 8, 2020

Conversation

adam2392
Copy link
Member

@adam2392 adam2392 commented Aug 5, 2020

PR Description

Closes: #348

Defaults to n/a for now to allow for easy grepping as @jasmainak suggested. Future improvements can be made that allow the status to change, pending an addition to mne-python, or implementation of #458

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"
  • Commit history does not contain any merge commits

@codecov-commenter
Copy link

codecov-commenter commented Aug 5, 2020

Codecov Report

Merging #489 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #489   +/-   ##
=======================================
  Coverage   92.79%   92.79%           
=======================================
  Files          14       14           
  Lines        1970     1971    +1     
=======================================
+ Hits         1828     1829    +1     
  Misses        142      142           
Impacted Files Coverage Δ
mne_bids/write.py 96.75% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fd2fa56...343d318. Read the comment docs.

@hoechenberger
Copy link
Member

I missed the discussion in #348, but since I've started working on #491 I'm wondering why you would want to fill it with n/a instead of empty strings?That's what I'm doing in #491 and I feel that that's the "better" way, because … well I feel that this string field should be empty if there's no explicit value set …

@adam2392
Copy link
Member Author

adam2392 commented Aug 6, 2020

I missed the discussion in #348, but since I've started working on #491 I'm wondering why you would want to fill it with n/a instead of empty strings?That's what I'm doing in #491 and I feel that that's the "better" way, because … well I feel that this string field should be empty if there's no explicit value set …

I think either value works, so can change it. That should pass the bids-validator right?

@hoechenberger
Copy link
Member

I think either value works, so can change it.

Let's see what the others think :)

That should pass the bids-validator right?

Hah, thanks for the reminder. I forgot to include BIDS validation in #491. Let's see…

@hoechenberger
Copy link
Member

Hah, thanks for the reminder. I forgot to include BIDS validation in #491. Let's see…

Ok so this is resolved now… won't pass the validation with an empty cell, so I'm using n/a now in #491 too as a default! :)

Copy link
Member

@hoechenberger hoechenberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hoechenberger
Copy link
Member

@sappelhoff Feel free to merge if you're happy

@agramfort
Copy link
Member

+0 on my side. I did not follow discussion.

@sappelhoff @jasmainak ball is in your hands

Copy link
Member

@sappelhoff sappelhoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -> doesn't hurt and will come in helpful when we have TSV + JSON updating functions

won't pass the validation with an empty cell, so I'm using n/a

yes, n/a is good here. 👍

@sappelhoff sappelhoff merged commit 8eec738 into mne-tools:master Aug 8, 2020
@sappelhoff
Copy link
Member

thanks @adam2392

@adam2392 adam2392 deleted the statusdescription branch August 27, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Status Description should be added to channels.tsv sidecar
5 participants