Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] Ensure raw.info['bads'] is a list #501

Merged
merged 2 commits into from Aug 11, 2020

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Aug 11, 2020

PR Description

In some cases we created info['bads'] as an ndarray, leading to unexpected behavior. MNE-Python docs say that it's expected to be a list.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"
  • Commit history does not contain any merge commits

In some cases we created info['bads'] as an ndarray, leading to
unexpected behavior. MNE-Python docs say that it's expected to be a
list.
@hoechenberger hoechenberger changed the title Ensure raw.info['bads'] is a list [MRG] Ensure raw.info['bads'] is a list Aug 11, 2020
@codecov-commenter
Copy link

Codecov Report

Merging #501 into master will increase coverage by 0.03%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #501      +/-   ##
==========================================
+ Coverage   92.79%   92.82%   +0.03%     
==========================================
  Files          14       14              
  Lines        1970     1980      +10     
==========================================
+ Hits         1828     1838      +10     
  Misses        142      142              
Impacted Files Coverage Δ
mne_bids/read.py 95.95% <100.00%> (+0.13%) ⬆️
mne_bids/write.py 96.75% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec031fa...f9ebea6. Read the comment docs.

@sappelhoff sappelhoff merged commit 84c2717 into mne-tools:master Aug 11, 2020
@sappelhoff
Copy link
Member

Thanks @hoechenberger

@hoechenberger hoechenberger deleted the read-bads-as-list branch August 11, 2020 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants