[MRG] Remove _estimate_line_freq #506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
updated whats_new fixed line freq test better formatting per Alex Mainak request good catch Alex small word change for email more descriptive name reduced to at least one channel for line_freq try n/a try more n/a tried improving powerline estimator remove line freq estimation
alexrockhill
force-pushed
the
no_line_freq
branch
from
a3cad61
to
a16d7ff
Compare
|
@mne-tools/mne-bids-contributors apparently validator requires PowerLineFrequency to be specified. It cannot be 'n/a' any opinion on this ? 2 options:
|
|
Option 2 makes more sense. To check while writing. |
|
ok I'll go with 2 here... doing it now |
agramfort
changed the title
Codecov Report
@@ Coverage Diff @@
## master #506 +/- ##
==========================================
- Coverage 92.79% 92.74% -0.06%
==========================================
Files 14 14
Lines 2055 2026 -29
==========================================
- Hits 1907 1879 -28
+ Misses 148 147 -1
Continue to review full report at Codecov.
|
hoechenberger
approved these changes
Aug 21, 2020
|
Thanks, @alexrockhill and @agramfort! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #503.
Describe your PR here
Merge checklist
Maintainer, please confirm the following before merging: