Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG: Fix handling of n/a event values when auto-renaming events on read #937

Merged
merged 6 commits into from Jan 7, 2022

Conversation

hoechenberger
Copy link
Member

@hoechenberger hoechenberger commented Jan 6, 2022

Fixes #936

Old:

The event "left" refers to multiple event values. Creating hierarchical event names.
    Renaming event: left -> left/n/a
    Renaming event: left -> left/n/a
    Renaming event: left -> left/1
    Renaming event: left -> left/n/a
    Renaming event: left -> left/n/a

New:

The event "left" refers to multiple event values. Creating hierarchical event names.
    Renaming event: left -> left/na
    Renaming event: left -> left/na
    Renaming event: left -> left/1
    Renaming event: left -> left/na
    Renaming event: left -> left/na

WIP:

  • Add tests
  • Add changelog entry

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@hoechenberger
Copy link
Member Author

CI failure is on Python 3.10 is unrelated to these changes

@hoechenberger hoechenberger marked this pull request as ready for review January 7, 2022 10:50
@hoechenberger hoechenberger changed the title Fix handling of n/a event values when auto-renaming events on read MRG: Fix handling of n/a event values when auto-renaming events on read Jan 7, 2022
Copy link
Member

@agramfort agramfort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know if CI issue is related

@hoechenberger
Copy link
Member Author

@agramfort CI issues seem to be fixed via 9fa710e, let's hope all comes back green now!

@codecov
Copy link

codecov bot commented Jan 7, 2022

Codecov Report

Merging #937 (33f63c9) into main (a497390) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #937   +/-   ##
=======================================
  Coverage   94.78%   94.78%           
=======================================
  Files          23       23           
  Lines        3490     3492    +2     
=======================================
+ Hits         3308     3310    +2     
  Misses        182      182           
Impacted Files Coverage Δ
mne_bids/read.py 95.84% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a497390...33f63c9. Read the comment docs.

@hoechenberger hoechenberger merged commit 0473a3e into mne-tools:main Jan 7, 2022
@hoechenberger hoechenberger deleted the hoechenberger/issue936 branch January 7, 2022 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automated event renaming doesn't always do the right thing
2 participants