Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MRG] explicitly declare pymatreader an optional dep for EEGLAB #952

Merged
merged 1 commit into from Jan 31, 2022

Conversation

sappelhoff
Copy link
Member

@sappelhoff sappelhoff commented Jan 31, 2022

Follow up to #951 - I think it's better to declare pymatreader an optional dependency, which it will become as soon as we drop mne < 1.0

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Jan 31, 2022

Codecov Report

Merging #952 (9d81e37) into main (92258b2) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
+ Coverage   94.39%   94.40%   +0.01%     
==========================================
  Files          25       25              
  Lines        3550     3559       +9     
==========================================
+ Hits         3351     3360       +9     
  Misses        199      199              
Impacted Files Coverage Δ
mne_bids/path.py 97.67% <0.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92258b2...9d81e37. Read the comment docs.

@sappelhoff sappelhoff changed the title explicitly declare pymatreader an optional dep for EEGLAB [MRG] explicitly declare pymatreader an optional dep for EEGLAB Jan 31, 2022
@hoechenberger hoechenberger merged commit 14625ed into mne-tools:main Jan 31, 2022
@hoechenberger
Copy link
Member

Thanks @sappelhoff

@sappelhoff sappelhoff deleted the reqs branch January 31, 2022 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants