Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ENH, MRG] Simplify reading dig #979

Merged
merged 3 commits into from Mar 7, 2022
Merged

Conversation

alexrockhill
Copy link
Contributor

@alexrockhill alexrockhill commented Mar 7, 2022

Okay, this is the penultimate PR from #973. This simplifies the reading logic for digitizations to give a consistent warning for all templates. It also allows 'unknown' to be set as the coordinate frame for MEG data, which technically should be allowable because template coordinate frames are acceptable for MEG too. It gets rid of most of the specific references to 'Other' in reading which is my favorite part because that really shouldn't be a part of BIDS.

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@alexrockhill
Copy link
Contributor Author

After this, the plan is to do similar restructuring for write and add both read and write to the example. Modifying write is a bit trickier because sometimes we use a different space (usually Other) that then MEG/EEG/IEEG_coord_system which really needs to be fixed because these are supposed to be the same thing.

@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #979 (e84b520) into main (7343e20) will increase coverage by 0.15%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #979      +/-   ##
==========================================
+ Coverage   94.72%   94.88%   +0.15%     
==========================================
  Files          25       25              
  Lines        3698     3675      -23     
==========================================
- Hits         3503     3487      -16     
+ Misses        195      188       -7     
Impacted Files Coverage Δ
mne_bids/config.py 97.43% <100.00%> (-0.13%) ⬇️
mne_bids/dig.py 95.39% <100.00%> (+2.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7343e20...e84b520. Read the comment docs.

doc/whats_new.rst Outdated Show resolved Hide resolved
Copy link
Member

@adam2392 adam2392 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah much better. I like it.

Co-authored-by: Adam Li <adam2392@gmail.com>
@hoechenberger
Copy link
Member

@adam2392 @alexrockhill
How confident are you that this is "safe" to merge just before the 0.10 release (which I had been planning to do tomorrow)?

@alexrockhill
Copy link
Contributor Author

IMO, I would prefer to get it done before the release, maybe we can have @timonmerk @moritz-gerster test

@hoechenberger
Copy link
Member

Alright, let's merge then once all is green!

@hoechenberger hoechenberger merged commit 33cbe67 into mne-tools:main Mar 7, 2022
@hoechenberger
Copy link
Member

Thanks @alexrockhill!

@alexrockhill alexrockhill deleted the ieeg branch March 7, 2022 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants