Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Adding sections to paper #87

Merged
merged 10 commits into from
Aug 3, 2022
Merged

[DOC] Adding sections to paper #87

merged 10 commits into from
Aug 3, 2022

Conversation

adam2392
Copy link
Member

@adam2392 adam2392 commented Jul 31, 2022

Thanks for contributing. If this is your first time,
make sure to read the contributing guide.

PR Description

Closes: #83

Also fixes: #86

cc: @TomDonoghue

Merge checklist

Maintainer, please confirm the following before merging:

  • All comments resolved
  • This is not your own PR
  • All CIs are happy
  • PR title starts with [MRG]
  • whats_new.rst is updated
  • PR description includes phrase "closes <#issue-number>"

@codecov
Copy link

codecov bot commented Jul 31, 2022

Codecov Report

Merging #87 (66ec859) into main (c0ddd1e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main      #87   +/-   ##
=======================================
  Coverage   86.90%   86.90%           
=======================================
  Files          22       22           
  Lines         863      863           
  Branches      104      104           
=======================================
  Hits          750      750           
  Misses         84       84           
  Partials       29       29           

Help us with your feedback. Take ten seconds to tell us how you rate us.

paper/paper.md Outdated Show resolved Hide resolved
paper/paper.md Outdated Show resolved Hide resolved
@adam2392
Copy link
Member Author

adam2392 commented Aug 1, 2022

@adam2392
Copy link
Member Author

adam2392 commented Aug 2, 2022

Kay once this is merged, I think the JOSS reviews will be addressed. Lmk if you have any final touches to add @mscheltienne @jacobf18 @anandsaini024

doc/index.rst Outdated Show resolved Hide resolved
Co-authored-by: Mathieu Scheltienne <mathieu.scheltienne@gmail.com>
@adam2392 adam2392 merged commit f740a59 into mne-tools:main Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Comments on the docsite Notes on JOSS paper
2 participants