[MNT] Improve packaging, managing of dependencies, and managing of ignored warning/errors

[mscheltienne]

Looking through the different configuration files for the different automatic checker/formatter/tests.. it's a bit messy and most of the stuff copy/pasted from MNE is probably not required here. Especially, I'm a bit worried by all the different ignore-clause which could mask issues.

So my plan is to try to simplify everything and see how it goes, and while I'm at it let's use pyproject.toml to its full potential. After the discussion in #49, I started playing around with the different packaging approaches, let's see if I can get something simpler here ;)

[adam2392]

If the rest works, I'll try explicitly setting the version for codecov.

[mscheltienne]

I tried running it on a different job, just to see if the timeout occurs again.

[mscheltienne]

@adam2393 Which commands from the Makefile are you using? I'd like to get rid of what we don't use.. as it is, I'm not sure even half of them are working anyway.

[mscheltienne]

And I think that line: https://github.com/mscheltienne/mne-icalabel/blob/9d35476815d74fd941545855d65d0f59c87741ad/.circleci/config.yml#L253
and that block: https://github.com/mscheltienne/mne-icalabel/blob/9d35476815d74fd941545855d65d0f59c87741ad/.circleci/config.yml#L5-L8
Can be both removed, the schedule parameters is not used in this workflow.

[adam2392]

@adam2393 Which commands from the Makefile are you using? I'd like to get rid of what we don't use.. as it is, I'm not sure even half of them are working anyway.

The ones for running checks, building docs, py testing and "clean". Everything else I don't use

[adam2392]

And I think that line: https://github.com/mscheltienne/mne-icalabel/blob/9d35476815d74fd941545855d65d0f59c87741ad/.circleci/config.yml#L253
and that block: https://github.com/mscheltienne/mne-icalabel/blob/9d35476815d74fd941545855d65d0f59c87741ad/.circleci/config.yml#L5-L8
Can be both removed, the schedule parameters is not used in this workflow.

Done

I've also cleaned up the Makefile now and edited the installation page.

[adam2392]

I tried running it on a different job, just to see if the timeout occurs again.

Python 3.9 isn't used, so codecov doesn't upload tho I just realized.

[mscheltienne]

Ahhh yes, that's a dumb one. I forgot that it tests only on the min/max version. Let's revert to 3.10 and see if the issue persists.

[adam2392]

Kay it works! one time error...

[adam2392]

In a downstream PR, we should try to do some maintenance to bring up test coverage to ~95%. Most likely these will come as we discover bugs w the added code for BIDs/GUI/etc. :p

[mscheltienne]

Timeouts can happen. Let's reread a bit through these changes both of us, and see if we have anything else we want to change. And then, good to merge.

[adam2392]

For these, I'm not 100% knowledgeable, is this the official version? E.g. I found this on the web: https://github.com/isort/isort-action.

Same for flake8 and mypy?

[mscheltienne]

I'm guessing jamescurtin/isort-action got renamed/moved to the isort namespace.. as I can't find anymore the GitHub page of jamescurtin/isort-action and as he his the main (almost only) contributor to that action ;)

Also: https://pycqa.github.io/isort/docs/configuration/github_action.html
Which does point to the new link, but I'm 99% sure it was pointing to jamescurtin namespace before ;)

I'll check them and update them.

[adam2392]

Everything else LGTM.

[mscheltienne]

LGTM, merging if CIs come back green.

[mscheltienne]

@adam2392 Looks like the doc-deploy image does not exist.