Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include MNE-ICALabel for macOS and Linux #123

Merged
merged 10 commits into from
May 11, 2022

Conversation

hoechenberger
Copy link
Member

No description provided.

@hoechenberger hoechenberger changed the title Include MNE-ICALabels Include MNE-ICALabel May 10, 2022
This reverts commit 25fd709.
@hoechenberger
Copy link
Member Author

All green, but on Windows the mne_icalabel import produces

2022-05-10T21:54:46.8675156Z Traceback (most recent call last):
2022-05-10T21:54:46.8679942Z   File "D:\a\mne-installers\mne-installers\tests\test_imports.py", line 12, in <module>
2022-05-10T21:54:46.8681235Z     import mne_icalabel
2022-05-10T21:54:46.8681827Z   File "C:\Users\runneradmin\mne-python\1.0.2_1\lib\site-packages\mne_icalabel\__init__.py", line 10, in <module>
2022-05-10T21:54:46.8682427Z     from .label_components import label_components  # noqa: F401
2022-05-10T21:54:46.8683047Z   File "C:\Users\runneradmin\mne-python\1.0.2_1\lib\site-packages\mne_icalabel\label_components.py", line 10, in <module>
2022-05-10T21:54:46.8683646Z     from .iclabel import iclabel_label_components
2022-05-10T21:54:46.8684249Z   File "C:\Users\runneradmin\mne-python\1.0.2_1\lib\site-packages\mne_icalabel\iclabel\__init__.py", line 7, in <module>
2022-05-10T21:54:46.8684925Z     from .label_components import iclabel_label_components  # noqa: F401
2022-05-10T21:54:46.8685881Z   File "C:\Users\runneradmin\mne-python\1.0.2_1\lib\site-packages\mne_icalabel\iclabel\label_components.py", line 8, in <module>
2022-05-10T21:54:46.8686528Z     from .network import run_iclabel
2022-05-10T21:54:46.8687091Z   File "C:\Users\runneradmin\mne-python\1.0.2_1\lib\site-packages\mne_icalabel\iclabel\network.py", line 7, in <module>
2022-05-10T21:54:46.8687704Z     import torch
2022-05-10T21:54:46.8688229Z   File "C:\Users\runneradmin\mne-python\1.0.2_1\lib\site-packages\torch\__init__.py", line 126, in <module>
2022-05-10T21:54:46.8688722Z     raise err
2022-05-10T21:54:46.8689546Z OSError: [WinError 182] The operating system cannot run %1. Error loading "C:\Users\runneradmin\mne-python\1.0.2_1\lib\site-packages\torch\lib\shm.dll" or one of its dependencies.

@hoechenberger
Copy link
Member Author

@larsoner Any idea why CI isn't aborting if Python throws an exception during one of our import tests?

@hoechenberger hoechenberger marked this pull request as draft May 11, 2022 07:30
@hoechenberger
Copy link
Member Author

hoechenberger commented May 11, 2022

For now I'm dropping Windows support for MNE-ICALabel as there are currently no Windows builds of PyTorch available from conda-forge; and when trying to use the official pytorch channel, I run into a DLL problem, which allegedly can be resolved when using certain packages (intel-openmp and potentially others) from the defaults channel (didn't work for me though); however, Anaconda Inc.'s terms of service could put some of our users at risk if they want to create a commercial product, if I'm not mistaken… @larsoner I suppose your English-foo for lawyer speak is much better than mine, could you take a look at the TOS and tell me what you think?

@hoechenberger hoechenberger changed the title Include MNE-ICALabel Include MNE-ICALabel for macOS and Linux May 11, 2022
@hoechenberger hoechenberger marked this pull request as ready for review May 11, 2022 08:17
@hoechenberger hoechenberger merged commit 0146da7 into mne-tools:main May 11, 2022
@larsoner
Copy link
Member

IANAL so I don't really know, but it doesn't seem worth the risk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants