Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyxdf #193

Merged
merged 15 commits into from
Jul 6, 2023
Merged

Add pyxdf #193

merged 15 commits into from
Jul 6, 2023

Conversation

cbrnr
Copy link
Collaborator

@cbrnr cbrnr commented Jul 6, 2023

Fixes #192.

@cbrnr
Copy link
Collaborator Author

cbrnr commented Jul 6, 2023

Is this the correct way to add a new dep? Should I upgrade outdated packages here as well?

@larsoner
Copy link
Member

larsoner commented Jul 6, 2023

You will need to upgrade the out of date ones then cross your fingers that the resolvers are happy. If they're not we have to isolate the problem and add an out-of-date exception. It's a bit tedious but it makes sure we're as up to date as possible

@cbrnr
Copy link
Collaborator Author

cbrnr commented Jul 6, 2023

"Hotfix for NSIS" fails, any ideas?

@larsoner
Copy link
Member

larsoner commented Jul 6, 2023

Looking at

They released a new version of nsis 2 months ago, maybe we need to pin to build _1 instead of allowing _2. Another possibility I thought might be menuinst but we already pin that one.

@cbrnr
Copy link
Collaborator Author

cbrnr commented Jul 6, 2023

The "NSIS Hotfix" job consists of this line (which will only run on Windows):

mamba install nsis=3.01 conda=4.12a

We're already pinning nsis=3.01. Do you mean that we should try using the latest version? I don't know what that hotfix does, why is it pinning these two packages in the first place?

@larsoner
Copy link
Member

larsoner commented Jul 6, 2023

@jaimergp it looks like our "hotfix for nsis" mamba install nsis=3.01 conda=4.12a has started to fail, see this log. Any ideas? Maybe we need to pin another package when doing this like conda? The conlist thing makes me think that maybe it's a conda list and min_items no longer exists on the newer conda version...?

@jaimergp
Copy link

jaimergp commented Jul 6, 2023

I think it must be the new pydantic. Pin it to pydantic <2.0a0.

@cbrnr
Copy link
Collaborator Author

cbrnr commented Jul 6, 2023

Apparently mamba install pydantic<2.0.0a1 doesn't work (sorry, I don't use mamba/conda)...

@larsoner
Copy link
Member

larsoner commented Jul 6, 2023

I think that might be a standard BASH issue with <, I'll push quotes to see if it helps

@cbrnr
Copy link
Collaborator Author

cbrnr commented Jul 6, 2023

I think that might be a standard BASH issue with <, I'll push quotes to see if it helps

Ah, of course! Good catch! It doesn't solve the original problem though 😢.

@larsoner larsoner enabled auto-merge (squash) July 6, 2023 17:56
@hoechenberger
Copy link
Member

Oh no, what a pain :(

@larsoner larsoner merged commit 31544ad into mne-tools:main Jul 6, 2023
13 checks passed
@cbrnr
Copy link
Collaborator Author

cbrnr commented Jul 6, 2023

Thanks @larsoner!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include pyxdf
4 participants