-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Move to Python 3.12 #213
Conversation
Still waiting on Numba and dipy (at least) here |
* upstream/main: [pre-commit.ci] pre-commit autoupdate (mne-tools#251) Build and test installers natively on Apple Silicon M1 (macOS 14) (mne-tools#249) [pre-commit.ci] pre-commit autoupdate (mne-tools#247)
@larsoner I see you removed TensorFlow, was this necessary to get the package to build? TF is an optional, yet important dependency of SleepECG. I believe classification without TF is either impossible or extremely slow. @cbrnr at least told me something along those lines, if I recall correctly Edit: looking at the SleepECG docs, classification is not possible w/o TF. We should try to include the TF package if possible! |
"conda", | ||
"mamba", # conda/mamba conflict with tensorflow and VTK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think we could resolve this somehow?
Also I started transitioning away from mamba
again in my personal dev environments, since conda
now uses the libmamba
solver by default, and it has this new feature where it can use your system certificates for TLS connections (you don't need to set a conda
-specific env var anymore if you use a self-signed cert that's mandated by a corporate firewall); mamba
is still lacking this feature
… this just to suggest that we may consider simply ditching mamba
if it causes trouble!
Yes, SleepECG needs TF for classification. |
TF is not available on Python 3.12. So we'll need to revert this if it's essential |
An auto rebuild triggered for OpenMEEG in conda-forge/openmeeg-feedstock#46 and I figured we might as well get this on our radar. Locally it still needs matplotlib so doesn't get very far: