Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Move to Python 3.12 #213

Merged
merged 9 commits into from
Feb 21, 2024
Merged

MAINT: Move to Python 3.12 #213

merged 9 commits into from
Feb 21, 2024

Conversation

larsoner
Copy link
Member

An auto rebuild triggered for OpenMEEG in conda-forge/openmeeg-feedstock#46 and I figured we might as well get this on our radar. Locally it still needs matplotlib so doesn't get very far:

$ ./tools/build_local.sh 
...
Channels:
 - conda-forge/label/python_rc
 - conda-forge
Platform: osx-arm64
Collecting package metadata (repodata.json): done
Solving environment: failed
...
Could not solve for environment specs
The following packages are incompatible
├─ python 3.12.0rc3**  is installable and it requires
│  └─ python_abi 3.12.* *_cp312, which can be installed;
└─ seaborn 0.12.2**  is not installable because it requires
   └─ seaborn-base >=0.12.2,<0.12.3.0a0 , which requires
      └─ matplotlib-base >=3.1,!=3.6.1  but there are no viable options
         ├─ matplotlib-base [3.3.2|3.3.3|...|3.7.3] would require
         │  └─ python_abi 3.8.* *_cp38, which conflicts with any installable versions previously reported;
         ├─ matplotlib-base [3.3.2|3.3.3|...|3.8.0] would require
         │  └─ python_abi 3.9.* *_cp39, which conflicts with any installable versions previously reported;
         ├─ matplotlib-base [3.4.3|3.5.0|...|3.8.0] would require
         │  └─ python_abi 3.10.* *_cp310, which conflicts with any installable versions previously reported;
         └─ matplotlib-base [3.6.2|3.6.3|...|3.8.0] would require
            └─ python_abi 3.11.* *_cp311, which conflicts with any installable versions previously reported.

@larsoner
Copy link
Member Author

Still waiting on Numba and dipy (at least) here

* upstream/main:
  [pre-commit.ci] pre-commit autoupdate (mne-tools#251)
  Build and test installers natively on Apple Silicon M1 (macOS 14) (mne-tools#249)
  [pre-commit.ci] pre-commit autoupdate (mne-tools#247)
@larsoner larsoner marked this pull request as ready for review February 21, 2024 15:37
@larsoner larsoner enabled auto-merge (squash) February 21, 2024 18:58
@larsoner larsoner merged commit 280639a into mne-tools:main Feb 21, 2024
15 checks passed
@hoechenberger
Copy link
Member

hoechenberger commented Feb 22, 2024

@larsoner I see you removed TensorFlow, was this necessary to get the package to build? TF is an optional, yet important dependency of SleepECG. I believe classification without TF is either impossible or extremely slow. @cbrnr at least told me something along those lines, if I recall correctly

Edit: looking at the SleepECG docs, classification is not possible w/o TF. We should try to include the TF package if possible!

Comment on lines 27 to 28
"conda",
"mamba", # conda/mamba conflict with tensorflow and VTK
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you think we could resolve this somehow?

Also I started transitioning away from mamba again in my personal dev environments, since conda now uses the libmamba solver by default, and it has this new feature where it can use your system certificates for TLS connections (you don't need to set a conda-specific env var anymore if you use a self-signed cert that's mandated by a corporate firewall); mamba is still lacking this feature

… this just to suggest that we may consider simply ditching mamba if it causes trouble!

@cbrnr
Copy link
Collaborator

cbrnr commented Feb 22, 2024

Yes, SleepECG needs TF for classification.

@larsoner
Copy link
Member Author

TF is not available on Python 3.12. So we'll need to revert this if it's essential

@larsoner larsoner deleted the 312 branch February 22, 2024 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants