Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: __len__ method for epochs #253

Closed
dengemann opened this issue Dec 12, 2012 · 5 comments
Closed

ENH: __len__ method for epochs #253

dengemann opened this issue Dec 12, 2012 · 5 comments

Comments

@dengemann
Copy link
Member

It's really a tiny one but I would love to say: len(epochs) and get len(epochs.events).
Any opinions / objections?

@dengemann
Copy link
Member Author

It could be len(events) as default and then get updated as bad epochs are dropped to be aligned with the shape of the data drawn from .get_data ... just throwing thoughts.

@mluessi
Copy link
Contributor

mluessi commented Dec 12, 2012

-1, as it depends on whether bad epochs have been dropped and dropping bad epochs first is not the usual procedure in the first place

@dengemann
Copy link
Member Author

I see, makes sense. Certainly not game changing just was thinking about it.

On Wed, Dec 12, 2012 at 1:57 PM, Martin Luessi notifications@github.comwrote:

-1, as it depends on whether bad epochs have been dropped and dropping bad
epochs first is not the usual procedure in the first place


Reply to this email directly or view it on GitHubhttps://github.com//issues/253#issuecomment-11287812.

@agramfort
Copy link
Member

-1 too. We had it before and we removed it exactly because of the problem of bad epochs. Closing this.

@dengemann
Copy link
Member Author

sure, good we discussed it ;-)

On Wed, Dec 12, 2012 at 2:19 PM, Alexandre Gramfort <
notifications@github.com> wrote:

-1 too. We had it before and we removed it exactly because of the problem
of bad epochs. Closing this.


Reply to this email directly or view it on GitHubhttps://github.com//issues/253#issuecomment-11288377.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants