MAINT: Remove code using vulture confidence 60 #12575
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larsoner
requested review from
drammock,
agramfort,
dengemann,
wmvanvliet,
adam2392,
mscheltienne,
alexrockhill,
hoechenberger,
jasmainak,
rob-luke,
sappelhoff and
cbrnr
as code owners
|
Wow this is massive |
drammock
reviewed
Apr 24, 2024
| def _replace_md5(fname): | ||
| """Replace a file based on MD5sum.""" | ||
| # adapted from sphinx-gallery | ||
| assert fname.endswith(".new") |
There was a problem hiding this comment.
this won't work for Path objects, is that OK?
There was a problem hiding this comment.
Must be, this is just copy-pasted 🙂
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Turns out we had a bunch of dead code. We also had a bunch of unused global vars in our test files which this caught!
This also makes me think that we should maybe add a test that checks the inventory of the testing dataset to make sure all files are used. Given the removals here it's possible that some no longer are, and it's either a bug and we should add them back somehow or we should remove them from the testing dataset...