-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix to sklearn imports. #3773
Fix to sklearn imports. #3773
Conversation
thanks a lot @jaeilepp let us know when travis is happy |
travis complains |
I'm not sure how we fixed the flake errors we get here. @Eric89GXL any idea? |
That shouldn't really happen because |
Oh, maint/0.12. You need to add to |
...but we should be careful when merging this, it is going to overwrite our |
I actually disabled the update of docs in an earlier push https://github.com/mne-tools/mne-python/blob/maint/0.12/circle.yml. |
Seems that the warnings for str.format are also disabled. Maybe the format fixes should be done on master too. My understanding is that |
That works fine on Py3k, but doesn't work on 2.6. Maybe that's what you're thinking of? In which case it's fine because we have dropped support for 2.6 |
https://travis-ci.org/mne-tools/mne-python/jobs/176711910#L2748 We need to change the decorator to |
1 similar comment
Travis now passes. I don't understand the problem with appveyor. |
ok that's good enough for me thx @jaeilepp |
I think there is something wrong with how sklearn handles deprecations. I couldn't find a better way to make it work on every platform.
EDIT: In the end, I think my setup was somehow wrong. Now it is cleaner than in the beginning.