New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VIZ, BUG: fix tickmarks in evoked topomap colorbar #7980
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe latest.inc
in BUG
stating that the colorbar ticks are fixed in topomap plotting?
@larsoner any idea why the CircleCI "details" link is going to the wrong job? Has this been noticed before? |
Do you have CircleCI enabled on your fork? If so it's probably larsoner/circleci-artifacts-redirector-action#7 |
Actually this is a CircleCI problem, I don't even see the artifacts here |
Oh wait that's the wrong job... |
So yes it's a CircleCI problem that for some reason the deploy status for |
yes, that's what I was just typing :) |
I submitted a ticket to CircleCI about this. |
Thanks @drammock |
* upstream/master: (21 commits) MRG: Add SSP projectors to Report (mne-tools#7991) BUG: Fix warning (mne-tools#8006) WIP: TFR Doc/test changes (mne-tools#7998) MAINT: Remove numpydoc test on 3.6 (mne-tools#8005) MAINT: Better error message for mismatch (mne-tools#8007) MRG: Allow removal of active projectors if channels they applied to have meanwhile been dropped (mne-tools#8003) MRG Freesurfer coordinate frame tutorial (mne-tools#7578) FIX: Fix stockwell checks (mne-tools#7996) MRG, ENH: Add array-spacing plugin and reorganize deps (mne-tools#7997) MRG, ENH: Reduce memory usage of Welch PSD (mne-tools#7994) STY: One more [ci skip] STY: Docstyle [ci skip] Report parsing (mne-tools#7990) MRG, ENH: BrainVision impedance parsing (mne-tools#7974) BUG: Fix missing source space points (mne-tools#7988) [MRG] Strip base directory name from Report captions when using parse_folder (mne-tools#7986) DOC: Update estimates [skip travis] (mne-tools#7987) DOC: Try to improve find_bad_channels_maxwell doc (mne-tools#7982) VIZ, BUG: fix tickmarks in evoked topomap colorbar (mne-tools#7980) Add low-pass filter to find_bad_channels_maxwell() (mne-tools#7983) ...
closes #7956
When the last topomap drawn has low variance and hence no visible contour lines, only one tickmark is drawn on the colorbar, because it uses the plotted contours instead of the precomputed contour levels based on vmin/vmax.
mne-python/mne/viz/topomap.py
Lines 1763 to 1764 in 2965cc3