Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MRG, BUG: Fix missing source space points #7988

Merged
merged 1 commit into from Jul 9, 2020
Merged

Conversation

larsoner
Copy link
Member

@larsoner larsoner commented Jul 9, 2020

Within release bugfix for bug introduced by #7763

Thanks for catching this @nordme, feel free to try with your data, hopefully it's fixed on this branch

@larsoner larsoner changed the title BUG: Fix missing source space points MRG, BUG: Fix missing source space points Jul 9, 2020
@larsoner
Copy link
Member Author

larsoner commented Jul 9, 2020

Missing on master:

https://mne.tools/dev/auto_tutorials/source-modeling/plot_forward.html

Fixed here:

https://21044-1301584-gh.circle-artifacts.com/0/dev/auto_tutorials/source-modeling/plot_forward.html

Azure seems to be having a bad day, I think we can (somewhat un)safely ignore it for now and hope MS magically fixes things.

@agramfort agramfort merged commit 4c4b927 into mne-tools:master Jul 9, 2020
@agramfort
Copy link
Member

thx @larsoner

@larsoner larsoner deleted the bem branch July 9, 2020 20:16
larsoner added a commit to larsoner/mne-python that referenced this pull request Jul 14, 2020
* upstream/master: (21 commits)
  MRG: Add SSP projectors to Report (mne-tools#7991)
  BUG: Fix warning (mne-tools#8006)
  WIP: TFR Doc/test changes (mne-tools#7998)
  MAINT: Remove numpydoc test on 3.6 (mne-tools#8005)
  MAINT: Better error message for mismatch (mne-tools#8007)
  MRG: Allow removal of active projectors if channels they applied to have meanwhile been dropped (mne-tools#8003)
  MRG Freesurfer coordinate frame tutorial (mne-tools#7578)
  FIX: Fix stockwell checks (mne-tools#7996)
  MRG, ENH: Add array-spacing plugin and reorganize deps (mne-tools#7997)
  MRG, ENH: Reduce memory usage of Welch PSD (mne-tools#7994)
  STY: One more [ci skip]
  STY: Docstyle [ci skip]
  Report parsing (mne-tools#7990)
  MRG, ENH: BrainVision impedance parsing (mne-tools#7974)
  BUG: Fix missing source space points (mne-tools#7988)
  [MRG] Strip base directory name from Report captions when using parse_folder (mne-tools#7986)
  DOC: Update estimates [skip travis] (mne-tools#7987)
  DOC: Try to improve find_bad_channels_maxwell doc (mne-tools#7982)
  VIZ, BUG: fix tickmarks in evoked topomap colorbar (mne-tools#7980)
  Add low-pass filter to find_bad_channels_maxwell() (mne-tools#7983)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants