Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Remove psd_welch usage and replace with Spectrum #45

Merged
merged 25 commits into from
Apr 5, 2023

Conversation

rob-luke
Copy link
Member

@rob-luke rob-luke commented Apr 5, 2023

I noticed in #44 that this usage of psd_welch was causing the documentation build to fail, so have updated it to use the newer spectrum object.

@rob-luke
Copy link
Member Author

rob-luke commented Apr 5, 2023

The docs now build on CircleCI but other warning are causing the tick to go ❌
See built doc here: https://output.circle-artifacts.com/output/job/a2de39c5-c644-4da1-9098-a86d7fd1c6f3/artifacts/0/dev/auto_examples/plot_ftclient_rt_compute_psd.html#sphx-glr-auto-examples-plot-ftclient-rt-compute-psd-py

Could we take a baby step here @larsoner @agramfort and merge this fix and then iterate?

@rob-luke
Copy link
Member Author

rob-luke commented Apr 5, 2023

Actually, a larger issue, I see that the pytest workflow has been disabled. @agramfort @larsoner @drammock could someone please enable it here: https://github.com/mne-tools/mne-realtime/actions/workflows/linux.yml thanks

@agramfort
Copy link
Member

agramfort commented Apr 5, 2023 via email

@larsoner larsoner mentioned this pull request Apr 5, 2023
@larsoner larsoner enabled auto-merge (squash) April 5, 2023 12:49
@larsoner larsoner disabled auto-merge April 5, 2023 13:44
@larsoner larsoner enabled auto-merge (squash) April 5, 2023 14:06
@larsoner larsoner merged commit 926b9dd into mne-tools:main Apr 5, 2023
@larsoner
Copy link
Member

larsoner commented Apr 5, 2023

Thanks for the fix @rob-luke , I snuck in a number of other maintenance stuff :)

@rob-luke
Copy link
Member Author

rob-luke commented Apr 5, 2023

Thanks @larsoner. And thanks for sneaking those other fixes in too, that's much quicker than me stringing PRs over a week 🚀

@rob-luke rob-luke deleted the welch branch April 5, 2023 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants