NumPy 1.12 support #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Support for array indexing with non integers indexes has been dropped on 1.12 version of numpy. [https://github.com/numpy/numpy/blob/master/doc/release/1.12.0-notes.rst#deprecationwarning-to-error](See release notes) The latest commit (e2600b7) fixes that error |
vfrico
force-pushed
the
master
branch
2 times, most recently
from
e968702
to
e2600b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a pull request because I'm using this library and is a feature I needed. Sometimes, when evaluating a model while it is training, the performance obtained with some hyperparameters can be really low. If so, it is better to stop the trainer friendly, adding this small lines of code, and test out another trainer with other hyperparameters.