Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add optional callback. #1

Closed

Conversation

jordanabderrachid
Copy link

No description provided.

@mnort9
Copy link
Owner

mnort9 commented Aug 10, 2016

Hey Jordan, thanks for contributing. I previously had an optional callback in an older version, but deprecated it. I didn't think anyone would want their app logic waiting on an analytics tool.

Can you give an example of how you would use the callback?

I'm hesitant to add it back because I may be adding additional arguments to the track functions to support future platform features. If the callback is added, all additional arguments will break backwards compatibility. It's not the end of the world to have to bump the major version, but I want to make sure adding it back is warranted.

@mnort9 mnort9 closed this Jan 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants