Don't bail if conneg bodies don't match, and downgrade from warning t…

…o info. Fixes #113.
mnot · Dec 4, 2012 · cfd3b2a · cfd3b2a
1 parent a66f987
commit cfd3b2a
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/redbot/speak.py b/redbot/speak.py
@@ -1109,15 +1109,17 @@ class VARY_HEADER_MISMATCH(Message):
 
 class VARY_BODY_MISMATCH(Message):
     category = c.CONNEG
-    level = l.WARN
+    level = l.INFO
     summary = {
      'en': u"The response body is different when content negotiation happens."
     }
     text = {
-     'en': u"""When content negotiation is used, the response body
+     'en': u"""When content negotiation is used, the response body typically
      shouldn't change between negotiated and non-negotiated
      responses.<p>
-     This might be because different servers handled the two requests.<p>"""
+     There might be legitimate reasons for this; e.g., because different
+     servers handled the two requests. However, RED's output may be skewed as
+     a result.<p>"""
     }
 
 class VARY_ETAG_DOESNT_CHANGE(Message):

diff --git a/redbot/subrequest/conneg.py b/redbot/subrequest/conneg.py
@@ -97,7 +97,6 @@ def done(self):
             # check body
             if self.base.res_body_post_md5 != self.state.res_body_md5:
                 self.set_message('body', rs.VARY_BODY_MISMATCH)
-                return  # Can't be sure what's going on...
 
             # check ETag
             if (self.state.parsed_hdrs.get('etag', 1) == \