-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Capacitor 4.0 support #39
Capacitor 4.0 support #39
Conversation
@AshleyMedway: Did you have any troubles with this Branch, Capacitor 4 and Android so far?
|
If you are confident that this works I'm happy to merge and release a new version asap, but I do not have the time to test it myself. BR |
Let me do some further testing today. I've got to do a regression of our app in Capacitor 4 today. Will report back :) |
I've tested the branch with a few devices (iOS and Android) and everything looks good so far. The error I mentioned above is still happening on Android as soon as a file gets shared, but it doesn't seem to have any negative consequences. |
in addition to the error mentioned above, my android app also crashes after sharing with the following exception:
Does anybody know how to fix this? A naive fix by changing the type of |
@hermitdemschoenenleben Did you install the PR with |
@tho-masn you're right, I was indeed misled by the description and checked out the wrong branch, sorry for that! With the |
I'm in the middle of releasing. Which version did you try. 4.0.0 is not released yet. |
@sander-spruit One more thing: I have no connection to ProteanSoftware. I have planned to do the release this weekend so your rather disrespectful behavior is for sure not the reason I'm releasing. Such comments are not motivating me to spend my spare time in providing open source software. |
I think #38 is missing the podspec and gradle changes
Additional if you want to install this early in your project you can run
npm i ProteanSoftware/capacitor-filesharer#master