Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Uses Adaptive.$ over Mobify.$ if it is defined #17

Closed
wants to merge 4 commits into from

Conversation

hora
Copy link

@hora hora commented May 28, 2014

Uses Adaptive.$ over Mobify.$ if it is defined

Status: Opened for visibility
Reviewers: *@scalvert @jansepar @donnielrt @kpeatt *

Changes

  • binds $ to Adaptive.$ if it's defined, otherwise falls back to Mobify.$ as before

Notes

  • this change is so we can continue to use bellows as a bower component beyond adaptive.js 0.1.18, since we extend Adaptive's selectorEngine with bellows
  • backwards-compatible

Horatiu Halmaghi and others added 4 commits May 27, 2014 16:56
On Samsung Galaxy S3 (Android 4.3 only) the wrong transition end event is used thus no Close event occurs and each bellows item can be opened only once.
@kpeatt
Copy link
Contributor

kpeatt commented Jul 7, 2014

@scalvert Is this an issue we need to fix in 2.0?

@scalvert
Copy link
Contributor

scalvert commented Jul 7, 2014

@kpeatt I think we need to figure out a better way of doing this. Ideally it uses some UMD wrapper.

@kpeatt
Copy link
Contributor

kpeatt commented Jul 7, 2014

@scalvert Okay, going to close this and assume we'll re-explore in 2.0 (#19).

@kpeatt kpeatt closed this Jul 7, 2014
@kpeatt kpeatt deleted the bind-to-Adaptive branch July 18, 2014 03:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants