Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Bellows 2.0 #28

Merged
merged 141 commits into from
Aug 26, 2014
Merged

Bellows 2.0 #28

merged 141 commits into from
Aug 26, 2014

Conversation

scalvert
Copy link
Contributor

Rewrite of bellows using new plugin format.

Status: Ready to merge

Reviewers: @jansepar @tedtate @donnielrt @kpeatt
JIRA: https://mobify.atlassian.net/browse/CSOPS-80

Changes

  • Rewrite of bellows js
  • Inclusion of velocity.js and velocity shim for Zepto (ick!)
  • Added new test infrastructure
  • Refactored Gruntfile into modular task loading

How to test-drive this PR

  • Checkout this branch
  • npm install && bower install
  • grunt test
  • grunt serve
  • View the examples page in the examples folder, and click around and stuff.

@kpeatt
Copy link
Contributor

kpeatt commented Jul 28, 2014

This is currently blocked by an issue with Velocity's jQuery shim on iOS6: julianshapiro/velocity#208

Once this is fixed, we should be Good to Merge™.

@tedtate
Copy link
Contributor

tedtate commented Aug 25, 2014

Tried this with AdaptiveJS 1.0 and received an error:

Uncaught TypeError: undefined is not a function bellows.js:140Bellows.open bellows.js:140Bellows.toggle bellows.js:118(anonymous function) bellows.js:79events.split.forEach.handler.proxy

Velocity is what looks to be undefined in this case.

My require config:

require.config({
    'paths': {
        'devicejs': '../../../bower_components/devicejs/lib/device.min',
        'bellows': '../../../bower_components/bellows/dist/bellows',
        'velocity': '../../../bower_components/velocity/velocity'
    }
});

@scalvert
Copy link
Contributor Author

Try now!

@tedtate
Copy link
Contributor

tedtate commented Aug 26, 2014

+1

scalvert added a commit that referenced this pull request Aug 26, 2014
@scalvert scalvert merged commit 691f064 into master Aug 26, 2014
@scalvert scalvert deleted the bellows-2.0 branch August 26, 2014 21:47
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

None yet

3 participants