Skip to content
This repository has been archived by the owner on Aug 5, 2020. It is now read-only.

Commit

Permalink
Minor fixes for combo
Browse files Browse the repository at this point in the history
Fixed wrong names for variable/function and initialized some variable.

The async function is still not working well, though. I can see the
following script as a result:

<script type="text/javascript">Mobify.combo.loadAsync('...');<br>Mobify.combo...

For some reason, there's <br> within the script.
  • Loading branch information
vmarta committed Jun 13, 2012
1 parent 024a25c commit 04e9a41
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
4 changes: 2 additions & 2 deletions api/combo-caching.js
Original file line number Diff line number Diff line change
Expand Up @@ -311,7 +311,7 @@ var ccPublic = /^\s*public\s*$/
storeResource(resource);
}

combo.dehydrateCache();
combo.storeCache();
}

/**
Expand Down Expand Up @@ -442,4 +442,4 @@ var ccPublic = /^\s*public\s*$/
}
};

})(Mobify);
})(Mobify);
6 changes: 3 additions & 3 deletions api/combo-client.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ var $ = Mobify.$

, comboScriptAsync = $.fn.comboScriptAsync = function() {
var $scripts = this.filter(defaults.selector).add(this.find(defaults.selector)).remove();
var url, urls, uncached, cached, $loaders;
var url, urls = [], uncached, cached, $loaders;

// Collect up urls
$scripts.filter('[' + defaults.attribute + ']').each( function() {
Expand All @@ -106,7 +106,7 @@ var $ = Mobify.$
cached = caching.cachedUrls(urls);
var loadCachedAsync = '';
for(var i = 0; i < cached.length; i++) {
cachedScriptloaderText += defaults.loadAsyncCallback +
loadCachedAsync += defaults.loadAsyncCallback +
"('" + cached[i] + "');\n";
}

Expand Down Expand Up @@ -142,4 +142,4 @@ var cssHost = 'combo.mobify.com'
return '//' + cssHost + '/css/' + JSONURIencode(object);
};

})(Mobify);
})(Mobify);

0 comments on commit 04e9a41

Please sign in to comment.